Skip to content

FIX: CI MacOS failures - #2466

Open
ritamerkl wants to merge 16 commits into
developfrom
fix-test-project-trunk-ci
Open

FIX: CI MacOS failures#2466
ritamerkl wants to merge 16 commits into
developfrom
fix-test-project-trunk-ci

Conversation

@ritamerkl

@ritamerkl ritamerkl commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Description

MacOS 6.7 failures:
The test-samples.yml hasn't been touched since 2022 and the macos-12 image has since lost its .NET installation (or the package-validation-suite started requiring it). The macos-13 image is what the mobile CI jobs use and is actively maintained.

Testing status & QA

None

Overall Product Risks

  • Complexity: Low
  • Halo Effect: Low

Comments to reviewers

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

The agent-image update is consistent with established macOS 13/M1 CI configurations in this repository.

Reviewed commit d8b7b50

🤖 Helpful? 👍/👎

@codecov-github-com

codecov-github-com Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2466   +/-   ##
========================================
  Coverage    78.95%   78.95%           
========================================
  Files          767      767           
  Lines       140780   140811   +31     
========================================
+ Hits        111153   111181   +28     
- Misses       29627    29630    +3     
Flag Coverage Δ
inputsystem_MacOS_6000.0 5.31% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.0_project 77.49% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3 5.31% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.3_project 77.48% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5 5.30% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.5_project 77.54% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.6 5.30% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.6_project 77.55% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.7 5.30% <ø> (-0.01%) ⬇️
inputsystem_MacOS_6000.7_project 77.55% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0 5.31% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.0_project 77.40% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3 5.31% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.3_project 77.39% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.5_project 77.45% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.6 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.6_project 77.45% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.7 5.30% <ø> (-0.01%) ⬇️
inputsystem_Ubuntu_6000.7_project 77.45% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0 5.31% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.0_project 77.61% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.3 5.31% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.3_project 77.61% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.5 5.30% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.5_project 77.67% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.6_project 77.67% <ø> (+0.04%) ⬆️
inputsystem_Windows_6000.7 5.30% <ø> (-0.01%) ⬇️
inputsystem_Windows_6000.7_project 77.68% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

ℹ️ Need help interpreting these results?

@ritamerkl ritamerkl changed the title FIX: CI Sample Test project failure FIX: CI Sample Test project failure & MacOS failures Aug 6, 2026
…runk-ci

# Conflicts:
#	.yamato/input-system-editor-functional-tests.yml
#	.yamato/input-system-editor-performance-tests.yml
#	.yamato/input-system-standalone-functional-tests.yml
#	.yamato/input-system-standalone-il2-cpp-functional-tests.yml
#	.yamato/input-system-standalone-il2-cpp-performance-tests.yml
#	.yamato/input-system-standalone-performance-tests.yml
@ritamerkl ritamerkl changed the title FIX: CI Sample Test project failure & MacOS failures FIX: CI MacOS failures Aug 7, 2026
@ritamerkl

Copy link
Copy Markdown
Collaborator Author

/review

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

LGTM

The current 6.7 CI matrix is consistent, but the platform override encodes an open-ended version rule as a pair of exact version strings.

Reviewed commit e18a173

🤖 Helpful? 👍/👎

Comment thread Tools/CI/Settings/InputSystemSettings.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant